fix(@nestjs/apollo): Add in missing peer dependencies. #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@netsjs/apollo` and `@nestjs/mercurius` packages rely on using `loadPackage('@apollo/subgraph')` but this package isn't reflected in either's package.json. This is incompatible with `pnpm`.
zackerydev
force-pushed
the
zgriesinger/fix-peers
branch
from
2bbfa62
to
a6d23c1
Compare
|
@jmcdo29 What's the path for getting this merged? |
cbjjensen
approved these changes
Jan 30, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@netsjs/apolloand@nestjs/mercuriuspackages rely on usingloadPackage('@apollo/subgraph')but this package isn't reflected in either's package.json. This is incompatible withpnpm.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information