feat: upgrade Mercurius, Apollo, GraphQL to the latest versions #2636

kamilmysliwiec · 2023-02-07T10:42:19Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

@lpessoa

co-authored: @lpessoa

@query

Fields with arguments are usually resolved using a separate method with the @ResolveField() annotation. Having such field generated as a required property thus proves quite cumbersome as it forces assigning a value in the result of parent @query() method. This makes fields with arguments always optional.

fix(deps): remove git conflict markers and keep latest rimraf version

Fixing pipes spec tests. Changed ApolloServerPluginInlineTraceDisabled reference to '@apollo/server/plugin/disabled'; Changed ApolloServerBase references to ApolloServer.

chore: fixing pipes and code-first spec tests and some code cleanup

luas10c · 2023-02-15T15:04:23Z

@kamilmysliwiec

You can get the latest changes from this repository check it out and pull it to fix the playground issue

https://github.com/luas10c/graphql

kamilmysliwiec · 2023-02-16T07:34:33Z

There's no "playground" issue. Current settings are intentional ant this was discussed several times in the past

packages/apollo/lib/drivers/apollo-base.driver.ts

Fix/apollo context

…ents-optional fix(graphql): generate fields as optional when they contain arguments

feat(types): Type check Field defaultValue

packages/apollo/package.json

kamilmysliwiec · 2023-03-01T11:21:42Z

nestjs/docs.nestjs.com#2640

Tony133 · 2023-03-02T10:11:33Z

packages/mercurius/package.json

-    "@nestjs/common": "8.4.7",
-    "@nestjs/platform-fastify": "8.4.7",
-    "@nestjs/testing": "8.4.7",
+    "@mercuriusjs/federation": "^1.0.0",


Suggested change

"@mercuriusjs/federation": "^1.0.0",

"@mercuriusjs/federation": "^1.0.1",

see here: https://github.com/mercurius-js/mercurius-federation/releases

Tony133 · 2023-03-02T10:11:39Z

packages/mercurius/package.json

-    "@nestjs/platform-fastify": "8.4.7",
-    "@nestjs/testing": "8.4.7",
+    "@mercuriusjs/federation": "^1.0.0",
+    "@mercuriusjs/gateway": "^1.0.0",


Suggested change

"@mercuriusjs/gateway": "^1.0.0",

"@mercuriusjs/gateway": "^1.2.0",

see here: https://github.com/mercurius-js/mercurius-gateway/releases

Tony133 · 2023-03-02T10:11:43Z

packages/mercurius/package.json

    "fastify": "4.12.0",
-    "mercurius": "8.13.2",
+    "mercurius": "12.0.0",


Suggested change

"mercurius": "12.0.0",

"mercurius": "12.2.0",

see here: https://github.com/mercurius-js/mercurius/releases

I don't think there are big changes in these small updates, they should solve small problems 😄, however I wanted to point this out before the release of the new version of the @nestjs/graphql package🙌

simplenotezy · 2023-03-08T23:37:04Z

Really cool @kamilmysliwiec - happy to see this, just as I was playing around tonight with upgrading our rather huge application from express to fastify.

What's the proper way to install the 'next' versions exactly? I'd love to test it out, and perhaps provide some feedback, if I should stumble upon anything. I've tried following your additions here: https://github.com/nestjs/docs.nestjs.com/pull/2640/files

I am getting package dependency conflicts. An example repo showing nest 9 running with graphql and fastify would be nice.

More specifically I am getting this error, when trying to pull in the next releases:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @nestjs/apollo@11.0.0-next.2
npm ERR! Found: @nestjs/graphql@11.0.0-next.2
npm ERR! node_modules/@nestjs/graphql
npm ERR!   @nestjs/graphql@"^11.0.0-next.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @nestjs/graphql@"^10.1.7" from @nestjs/apollo@11.0.0-next.2
npm ERR! node_modules/@nestjs/apollo
npm ERR!   @nestjs/apollo@"^11.0.0-next.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @nestjs/graphql@10.2.0
npm ERR! node_modules/@nestjs/graphql
npm ERR!   peer @nestjs/graphql@"^10.1.7" from @nestjs/apollo@11.0.0-next.2
npm ERR!   node_modules/@nestjs/apollo
npm ERR!     @nestjs/apollo@"^11.0.0-next.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

kamilmysliwiec · 2023-03-09T07:16:48Z

@simplenotezy you can use the --legacy-peer-deps flag for now (when installing packages)

simplenotezy · 2023-03-09T13:46:58Z

Thanks @kamilmysliwiec - I'll do that!

Martin Kagamino Lehoux and others added 30 commits August 29, 2022 08:35

feat(graphql): type check field default value

7d0438a

chore(deps): upgrade graphql and add apollo server v4

779b72d

feat(add): graphql exceptions

b6a9b72

fix(graphql): fix errors and update graphql v16.6

29882ae

feat(add): add folder constants

cdf4998

fix(graphql): fix writing http status code

951f907

feat(apollo): remove old packages

132f44a

chore(graphql): update package version

2b4f04d

chore(mercurius): update package version

6ea10c3

chore(deps): update lock

82b89db

chore(deps): update deps and lock file

3c7db81

feat(apollo): fix cors and add @fastify/cors when wrapped by fastify

2f979fa

co-authored: @lpessoa

chore(deps): update dependency rimraf to v4.0.5

7aaa398

chore(deps): update dependency eslint to v8.32.0

3d990ff

chore(deps): update dependency rimraf to v4.0.7

46833e5

chore(deps): update typescript-eslint monorepo to v5.48.2

e59a936

chore(deps): update dependency eslint-plugin-import to v2.27.5

e66a795

chore(deps): update dependency @types/jest to v29.2.6

80c3dba

chore(deps): update typescript-eslint monorepo to v5.49.0

af08334

chore(deps): update dependency rimraf to v4.1.2

95cb42f

chore(deps): update dependency jest to v29.4.0

d482f33

chore(deps): update dependency @types/jest to v29.4.0

c990c84

chore(deps): update apollo graphql packages to v2.3.0

d737999

chore(deps): update dependency jest to v29.4.1

6ba05c5

chore(deps): update dependency eslint to v8.33.0

3a879d9

fix(deps): remove git conflict markers and keep latest rimraf version

93c27d3

Merge pull request #1 from paologf/upgrade/apollo-v4

c49e4b2

fix(deps): remove git conflict markers and keep latest rimraf version

chore: fixing pipes and code-first spec tests and some code cleanup

b46d9b4

Fixing pipes spec tests. Changed ApolloServerPluginInlineTraceDisabled reference to '@apollo/server/plugin/disabled'; Changed ApolloServerBase references to ApolloServer.

Merge pull request #2 from lpessoa/upgrade/apollo-v4

250639a

chore: fixing pipes and code-first spec tests and some code cleanup

Davide-Gheri reviewed Feb 17, 2023

View reviewed changes

packages/apollo/lib/drivers/apollo-base.driver.ts Outdated Show resolved Hide resolved

Davide-Gheri added 4 commits February 20, 2023 13:51

fix: pass context fn to server middleware

a904e67

fix: apollo server expects context to always return a promise

8290923

fix: correctly pass request to context with fastify adapter

5a1e97c

test: custom context is available to resolvers

291d5c5

Davide-Gheri mentioned this pull request Feb 20, 2023

Fix/apollo context #2662

Merged

6 tasks

kamilmysliwiec added 3 commits February 24, 2023 12:55

Merge pull request #2662 from Davide-Gheri/fix/apollo-context

2f6b55d

Fix/apollo context

Merge pull request #2623 from arthurtemple/make-properties-with-argum…

15fd4e3

…ents-optional fix(graphql): generate fields as optional when they contain arguments

Merge pull request #2330 from martinlehoux/master

6c5d222

feat(types): Type check Field defaultValue

kamilmysliwiec commented Feb 28, 2023

View reviewed changes

packages/apollo/package.json Outdated Show resolved Hide resolved

kamilmysliwiec added 3 commits March 1, 2023 11:40

chore: move apollo server to peer deps

741937c

feat(apollo): add wrapper error classes

7072504

v11.0.0-next.2

64494db

Tony133 suggested changes Mar 2, 2023

View reviewed changes

This was referenced Mar 6, 2023

Apollo fastify server workaround #2582

Closed

Apollo 4 with fastify server #2682

Closed

@nestjs/platform-fastify: fastify version mismatch Apollo v3 requirements #2307

Closed

kamilmysliwiec mentioned this pull request Mar 9, 2023

Switch to @apollo/server package #2697

Closed

1 task

kamilmysliwiec added 3 commits March 10, 2023 10:54

chore: resolve conflicts

8df948d

test: update snapshot

4b2b173

test: skip mercurius gateway test

e667c69

kamilmysliwiec merged commit 1dc229a into master Mar 10, 2023

delete-merged-branch bot deleted the next branch March 10, 2023 10:09

rhutchison mentioned this pull request Mar 28, 2023

Configuring CORS #2752

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade Mercurius, Apollo, GraphQL to the latest versions #2636

feat: upgrade Mercurius, Apollo, GraphQL to the latest versions #2636

kamilmysliwiec commented Feb 7, 2023

luas10c commented Feb 15, 2023 •

edited

Loading

kamilmysliwiec commented Feb 16, 2023

kamilmysliwiec commented Mar 1, 2023

Tony133 Mar 2, 2023

Tony133 Mar 2, 2023

Tony133 Mar 2, 2023

Tony133 Mar 2, 2023

simplenotezy commented Mar 8, 2023 •

edited

Loading

kamilmysliwiec commented Mar 9, 2023

simplenotezy commented Mar 9, 2023

	"@mercuriusjs/federation": "^1.0.0",
	"@mercuriusjs/federation": "^1.0.1",

	"@mercuriusjs/gateway": "^1.0.0",
	"@mercuriusjs/gateway": "^1.2.0",

feat: upgrade Mercurius, Apollo, GraphQL to the latest versions #2636

feat: upgrade Mercurius, Apollo, GraphQL to the latest versions #2636

Conversation

kamilmysliwiec commented Feb 7, 2023

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

luas10c commented Feb 15, 2023 • edited Loading

kamilmysliwiec commented Feb 16, 2023

kamilmysliwiec commented Mar 1, 2023

Tony133 Mar 2, 2023

Choose a reason for hiding this comment

Tony133 Mar 2, 2023

Choose a reason for hiding this comment

Tony133 Mar 2, 2023

Choose a reason for hiding this comment

Tony133 Mar 2, 2023

Choose a reason for hiding this comment

simplenotezy commented Mar 8, 2023 • edited Loading

kamilmysliwiec commented Mar 9, 2023

simplenotezy commented Mar 9, 2023

luas10c commented Feb 15, 2023 •

edited

Loading

simplenotezy commented Mar 8, 2023 •

edited

Loading