Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): support resolverValidationOptions for schema first federation #3115

Merged

Conversation

seyfert
Copy link
Contributor

@seyfert seyfert commented Jan 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The option for resolverValidationOptions isn't being passed along to addResolversToSchema despite it being included in graphql federation options and it being supported by addResolversToSchema.

Related to #2994

Issue Number: N/A

What is the new behavior?

Support resolverValidationOptions for schema first federation

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 4983208 into nestjs:master Feb 7, 2024
1 check passed
@seyfert seyfert deleted the federation-build-schema-options branch February 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants