Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): add support for option newline at the end of schema file #3222

Conversation

sabolch
Copy link
Contributor

@sabolch sabolch commented Jun 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #2732

What is the new behavior?

Added new option addNewlineAtEnd to BuildSchemaOptions, which appends a newline at the end of the generated GraphQL SDL file when set to true. If the option is set to false or omitted, the SDL file will be generated without adding an extra newline at the end.
This option is applicable only in the code-first approach.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 4e711d1 into nestjs:master Jul 2, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants