feat(@nestjs/graphql): add support for skipNullProperties in PartialType #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding the same skipNullProperties as this PR https://github.com/nestjs/swagger/pull/2863/files added for the Swagger version of PartialType. Original feature coming from this Mapped-Type PR nestjs/mapped-types#1274
Issue Number: N/A
What is the new behavior?
PartialType can optionally return a class for which validations are ignored only for undefined properties, not null properties. This can be useful if you are creating a DTO for a mutation endpoint: there may be a certain field, say name, that should not be null, but which doesn't need to be included in updates.
Does this PR introduce a breaking change?
Other information