Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo): map unprocessable entity code to bad user input #3330

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kishieel
Copy link
Contributor

@kishieel kishieel commented Oct 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The code in error extensions is INTERNAL_SERVER_ERROR if we set HttpStatus.UNPROCESSABLE_ENTITY for ValidationPipe.

{
  "errors": [
    {
      "extensions": {
        "code": "INTERNAL_SERVER_ERROR",
      }
    }
  ]
}

What is the new behavior?

The code in error extensions is BAD_USER_INPUT.

{
  "errors": [
    {
      "extensions": {
        "code": "BAD_USER_INPUT",
      }
    }
  ]
}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Can we have it merged please or there is some reason why this mapping was not added before?

@kostnerek
Copy link

Nice PR, thought about it somę time ago, just didnt have time to make it! @kamilmysliwiec look and it

@kamilmysliwiec
Copy link
Member

lgtm

@kamilmysliwiec kamilmysliwiec merged commit 708fbc6 into nestjs:master Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants