Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): JWT_MODULE_OPTIONS set to be optional #955

Merged
merged 1 commit into from
May 19, 2022

Conversation

flamewow
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the new behavior?

JWT_MODULE_OPTIONS is now optional, so we can import the module as

...
   imports: [JwtModule, ],
...

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@flamewow flamewow marked this pull request as ready for review May 18, 2022 13:58
@flamewow flamewow changed the title made JWT_MODULE_OPTIONS an optional inject feat(): JWT_MODULE_OPTIONS set to be optional May 18, 2022
@kamilmysliwiec kamilmysliwiec merged commit c5c2939 into nestjs:master May 19, 2022
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants