Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create the connection as a promise with asPromise #1083

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Oct 19, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Connections injected with @InjectConnection() might not be initialised

Issue Number: #1082

What is the new behavior?

Connections injected with @InjectConnection() will be ready to use

Does this PR introduce a breaking change?

[ ] Yes
[X] No

I've tested this by modifying the JS in the node_modules and it does work as expected

@kamilmysliwiec
Copy link
Member

LGTM

@jmcdo29 jmcdo29 deleted the fix/mongoose-connection branch October 20, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants