Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reloading compiled model if already existed #1868

Conversation

omarberrami
Copy link

update createMongooseProviders to prevent reloading compiled model if already existed, and return the loaded one

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 1867
#1867

What is the new behavior?

Load the models without problemes, if the model are already compiled non need to overwrite.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

createMongooseProviders to prevent reloading compiled model if already existed, and return the loaded one
@omarberrami omarberrami changed the title update createMongooseProviders revent reloading compiled model if already existed Jul 19, 2023
@omarberrami omarberrami changed the title revent reloading compiled model if already existed Prevent reloading compiled model if already existed Jul 19, 2023
@kamilmysliwiec kamilmysliwiec merged commit 720f868 into nestjs:master Jul 20, 2023
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants