-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added onconnectioncreate module option #2096
Merged
kamilmysliwiec
merged 5 commits into
nestjs:master
from
prateekkathal:on-connection-create
Apr 12, 2024
Merged
feat: added onconnectioncreate module option #2096
kamilmysliwiec
merged 5 commits into
nestjs:master
from
prateekkathal:on-connection-create
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgtm |
10 tasks
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1290
What is the new behavior?
According to Mongoose Documentation, the event listeners should be added immediately after
createConnection
. By adding thisonConnectionCreate
function as a module option, we can bypass the limits of theconnectionFactory
function.The same will work for
forRootAsync()
.Does this PR introduce a breaking change?
Other information
I can create the Main Docs PR if changes are approved.