-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): expose external-context-creator #11104
Merged
kamilmysliwiec
merged 1 commit into
nestjs:master
from
eugenk:feature/expose-external-context-creator
Mar 10, 2023
Merged
feat(core): expose external-context-creator #11104
kamilmysliwiec
merged 1 commit into
nestjs:master
from
eugenk:feature/expose-external-context-creator
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow third party packages to register handlers (like controller methods) that pass through the whole pipeline of interceptors, pipes, guards, filters and param decorators while still being compliant with node16 moduleResolution, where imports like ```typescript import { ExternalContextCreator, ParamsFactory, } from "@nestjs/core/helpers/external-context-creator"; ``` are not allowed. No tests are added here because functionality is not changed.
Pull Request Test Coverage Report for Build f2b7d659-23a2-4636-8ade-306e9a11733b
💛 - Coveralls |
LGTM |
This was referenced Jul 20, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow third party packages to register handlers (like controller methods) that pass through the whole pipeline of interceptors, pipes, guards, filters and param decorators while still being compliant with node16 moduleResolution, where imports like
are not allowed.
No tests are added here because functionality is not changed.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ExternalContextCreator
andParamsFactory
are not exposed for third party packages to use.Issue Number: N/A
What is the new behavior?
ExternalContextCreator
andParamsFactory
are exposed for third party packages to use.Does this PR introduce a breaking change?
Other information
No tests are added because no functionality has changed. Only existing functionality has been exposed to the API.