-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ws): filter only nil results #11186
Merged
kamilmysliwiec
merged 1 commit into
nestjs:master
from
CodyTseng:fix-ws-adaptor-filter-non-nil-result
Mar 10, 2023
Merged
fix(ws): filter only nil results #11186
kamilmysliwiec
merged 1 commit into
nestjs:master
from
CodyTseng:fix-ws-adaptor-filter-non-nil-result
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyTseng
changed the title
fix(ws): filter non nil result
fix(ws): filter only nil results
Mar 3, 2023
Pull Request Test Coverage Report for Build 897ec688-b228-40a3-9dc1-fc6fb90f5c52
💛 - Coveralls |
kamilmysliwiec
added
scope: websockets
type: bug 😭
scope: platform
and removed
scope: websockets
labels
Mar 10, 2023
lgtm |
This was referenced Jul 20, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
If the message handler return
false
, thews-adapter
will filter this result.What is the new behavior?
Only nil results will be filtered. This behavior is the same as
io-adapter
.Does this PR introduce a breaking change?
Other information
By the way, I don't think
null
should be filtered 🤔.