-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ws): mount multi ws
servers on different paths
#11188
Merged
kamilmysliwiec
merged 2 commits into
nestjs:master
from
CodyTseng:fix-ws-multi-servers-on-different-paths
Apr 5, 2023
Merged
fix(ws): mount multi ws
servers on different paths
#11188
kamilmysliwiec
merged 2 commits into
nestjs:master
from
CodyTseng:fix-ws-multi-servers-on-different-paths
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3dcfc662-2d8e-4349-bfd2-7f9a026746ee
💛 - Coveralls |
This was referenced May 24, 2024
This was referenced Jul 20, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
The
path
parameter does not work as expected. Because thepath
andnoServer
parameters can only be provided one. https://github.com/websockets/ws/blob/HEAD/doc/ws.md#new-websocketserveroptions-callbacknest/packages/platform-ws/adapters/ws-adapter.ts
Lines 85 to 90 in 06b7960
The
wsOptions
contain thepath
parameter.What is the new behavior?
Multiple
ws
servers can be successfully mounted on different paths as described in the documentation.Does this PR introduce a breaking change?
Other information