refactor(fastify): updated static options #11995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1bb53f98-8fe9-49f2-ad3f-702264b3cf92
💛 - Coveralls |
Tony133
approved these changes
Jul 10, 2023
ghost
reviewed
Jul 12, 2023
| * @param localOptions | ||
| * | ||
| * @param localOptions | ||
| * |
There was a problem hiding this comment.
These spacing changes are unrelated to the commit aren't they? If so, they shouldn't be in it, and rather submited as a separate PR for formatting
There was a problem hiding this comment.
@jrobeson changed the PR to contain only the changes that I've made.
Mojtaba-NA
force-pushed
the
fastify-static-options-changes
branch
from
535f54b
to
629715d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
since version 6.10.0, fastify-static added an option to specify route constraints. I've just updated the interface in platform-fastify package to reflect the latest type in fastify-static package.
fastify-static v6.10.0 changelog
Does this PR introduce a breaking change?
Other information