-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): fix stacktrace regex #13317
Merged
kamilmysliwiec
merged 1 commit into
nestjs:master
from
hokaccha:fix-console-logger-is-stack
Mar 17, 2024
Merged
fix(common): fix stacktrace regex #13317
kamilmysliwiec
merged 1 commit into
nestjs:master
from
hokaccha:fix-console-logger-is-stack
Mar 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokaccha
commented
Mar 13, 2024
@@ -343,7 +343,7 @@ export class ConsoleLogger implements LoggerService { | |||
return false; | |||
} | |||
|
|||
return /^(.)+\n\s+at .+:\d+:\d+$/.test(stack); | |||
return /^(.)+\n\s+at .+:\d+:\d+/.test(stack); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual string of stacktrace does not end with a number.
Error: err!
at bootstrap (/path/to/src/main.ts:30:15)
Pull Request Test Coverage Report for Build c4df0b41-381f-4f89-986c-a7e58165c4faDetails
💛 - Coveralls |
LGTM |
This was referenced Jun 21, 2024
This was referenced Jun 29, 2024
This was referenced Jul 19, 2024
This was referenced Aug 21, 2024
Open
This was referenced Sep 13, 2024
This was referenced Sep 20, 2024
This was referenced Sep 25, 2024
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
output:
What is the new behavior?
Does this PR introduce a breaking change?
Other information