Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): middleware is not executed for root route when global prefix is set #13337

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #11572

What is the new behavior?

Based off #12179

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7adabfa0-ed39-40ba-9e86-028b02c6c50f

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.146%

Totals Coverage Status
Change from base Build 68ba9650-c952-423f-be1b-e55bad701ad4: 0.0%
Covered Lines: 6734
Relevant Lines: 7308

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 40800d3 into master Mar 18, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/global-prefix-midleware-issue branch March 18, 2024 11:42
@B4nan
Copy link

B4nan commented Mar 20, 2024

I'll have to check this myself, but I already heard from two of our users that this is not fixing the actual problem, at least not for the MikroORM integration.

@eric-deeporigin
Copy link

This is still not working for our apps even with latest version of nest (10.3.8), particularly with the MikroORM integration

@kamilmysliwiec
Copy link
Member Author

Could you please provide a minimum reproduction repository @eric-deeporigin?

@renanz
Copy link

renanz commented Jun 21, 2024

Could you please provide a minimum reproduction repository @eric-deeporigin?

@kamilmysliwiec #13401 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants