Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(microservices): fix redundant code to emit error" #13367

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Revert "fix(microservices): fix redundant code to emit error" #13367

merged 1 commit into from
Mar 27, 2024

Conversation

kamilmysliwiec
Copy link
Member

Reverts #13328

@kamilmysliwiec kamilmysliwiec merged commit 872ab40 into master Mar 27, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the revert-13328-fix/redundant-emit-code branch March 27, 2024 07:34
@kamilmysliwiec kamilmysliwiec mentioned this pull request Mar 27, 2024
Closed
2 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 846512ad-0ace-460f-9699-db8973122bac

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.125%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-grpc.ts 6 8 75.0%
Totals Coverage Status
Change from base Build b41ad400-7d26-483f-b16f-c94b0a88503b: -0.02%
Covered Lines: 6738
Relevant Lines: 7314
💛 - Coveralls

@AbdulHakkam AbdulHakkam mentioned this pull request May 25, 2024
Open
@DeanAyalon DeanAyalon mentioned this pull request Jun 1, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Jun 4, 2024
Open
@ai-leonid ai-leonid mentioned this pull request Jun 6, 2024
Open
@abjerry97 abjerry97 mentioned this pull request Jun 12, 2024
Open
@dagistan-tuncbilek dagistan-tuncbilek mentioned this pull request Jun 14, 2024
Open
@Cabreira97 Cabreira97 mentioned this pull request Jun 18, 2024
Merged
This was referenced Jun 21, 2024
Open
Open
@ai-leonid ai-leonid mentioned this pull request Jun 25, 2024
Open
@Cabreira97 Cabreira97 mentioned this pull request Jun 25, 2024
Merged
This was referenced Jun 29, 2024
Closed
Merged
Merged
Merged
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@origranot origranot mentioned this pull request Jul 17, 2024
Merged
@WontonSam WontonSam mentioned this pull request Jul 19, 2024
Open
This was referenced Jul 19, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Aug 4, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 17, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 15, 2024
Open
@XavierMP14 XavierMP14 mentioned this pull request Sep 17, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 17, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 18, 2024
Open
@mauriciocarvalho01 mauriciocarvalho01 mentioned this pull request Sep 19, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 19, 2024
Open
This was referenced Sep 20, 2024
Open
Open
Open
@m0hs1ne m0hs1ne mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Oct 18, 2024
Open
This was referenced Oct 25, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
@ajile-in ajile-in mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: microservices type: bug 😭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilmysliwiec @coveralls