Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common,core): align the logic of optional provider #14175

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #14154

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 078f600e-2d2f-4905-8549-65f3a86325aa

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.989%

Totals Coverage Status
Change from base Build 6238ab1b-926d-4730-8065-a1f869d645fd: 0.0%
Covered Lines: 6809
Relevant Lines: 7402

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit a1732f5 into nestjs:master Nov 21, 2024
5 checks passed
@micalevisk micalevisk deleted the fix-issue-14154 branch November 21, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the logic of isOptionalFactoryDependency internal utility
3 participants