fix(common): preserve default description for teapot exception #15962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply default description ("I'm a teapot") when HttpExceptionOptions are provided without an explicit description. previously, passing only an options object such as { cause } resulted in description being undefined because extractDescriptionAndOptionsFrom() does not apply any fallback. this change restores consistent behavior with other built-in HTTP exceptions, which all preserve their default descriptions when options are provided without a description.
Closes nestjs#15961
Pull Request Test Coverage Report for Build 93b73477-6464-42f0-9045-630caa928193Details
💛 - Coveralls |
|
Love the PR but there are so many more exceptions: |
malkovitc
pushed a commit
to malkovitc/nest
that referenced
this pull request
Dec 2, 2025
…n using options
When providing HttpExceptionOptions (e.g., { cause }) without an explicit
description, the default description was lost because extractDescriptionAndOptionsFrom()
returns undefined for the description property.
This fix applies the same pattern used in PR nestjs#15962 for ImATeapotException to all
built-in HTTP exceptions: using destructuring default values to preserve the
default description when options are provided without an explicit description.
Closes nestjs#15961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply default description ("I'm a teapot") when HttpExceptionOptions are provided without an explicit description. previously, passing only an options object such as { cause } resulted in description being undefined because extractDescriptionAndOptionsFrom() does not apply any fallback. this change restores consistent behavior with other built-in HTTP exceptions, which all preserve their default descriptions when options are provided without a description.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #15961
What is the new behavior?
Does this PR introduce a breaking change?
Other information