fix(common): move file-type to optional peer dependency #16012
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move file-type from dependencies to peerDependencies to resolve npm hoisting issues. When other packages depend on older file-type versions, npm may hoist the incompatible version to root node_modules, causing FileTypeValidator to load the wrong version. By making file-type an optional peer dependency with version ^21.0.0, npm will warn about version conflicts and ensure the correct version is used. Closes nestjs#15270
2 tasks
Pull Request Test Coverage Report for Build f7887e28-8e3d-458a-b464-75f285ef93b5Details
💛 - Coveralls |
micalevisk
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
file-typefromdependenciestopeerDependenciesto resolve npm hoisting issues.Problem
When another package (like
jimp) depends on an older version offile-type, npm may hoist that older version to the rootnode_modules. The dynamic import inFileTypeValidatorthen loads the wrong version, causing validation failures with cryptic error messages like:Solution
Moved (not added)
file-typefromdependenciestopeerDependenciesas optional:file-type: "21.1.1"fromdependenciesfile-type: "^21.0.0"topeerDependenciesoptional: trueinpeerDependenciesMetaThis ensures npm warns users when an incompatible version would be hoisted, while not breaking projects that don't use
FileTypeValidator.Test plan
Related
Closes #15270