Fix to RMQ socketoptions being incorrectly passed to ampq-connection-manager

[christianallred]

PR Type

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

RMQ microservices were not properly passing over the the heartbeatIntervalInSeconds to the amqp-connection-manager and the only way to get it work as expected was to pass in a url object with the heartbeat value in the object.

Issue Number: 5788

What is the new behavior?

I have updated the object being passed to amqp-connection-manager to match the footprint they expect so that socket options are properly accepted.

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

Expected footprint for amqp-connection-manager options
https://github.com/jwalton/node-amqp-connection-manager

{
     connectionOptions: any
     hartbeatIntervalInSeconds: number
     reconnectTimeInSeconds: number
     findServers: callback
}

[coveralls]

Pull Request Test Coverage Report for Build d308d8fa-8567-479a-9c90-93bcad83dfd8

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 94.616%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/microservices/server/server-rmq.ts	0	3	0.0%

Totals
Change from base Build 24d3285b-41a3-4820-9784-4ec138ed78e2:	-0.04%
Covered Lines:	5008
Relevant Lines:	5293

---

💛 - Coveralls

[jmcdo29]

Can you add a regression test to ensure this is doing what is expected, and to help it from failing in the future?

[jmcdo29]

While the comment is nice, it should be in the pull request or the commit message so that it's referencable without being in the code.

[christianallred]

Updated PR to contain this. removed comment from code. I'll work on a regression test later tonight

[christianallred]

I've added the typings for this as well to help with programming a bit more. if i have time later this week i will add the typings for queueOptions as well. shouldn't be too bad. I didn't have time to write the regression tests yet. Im admittedly not the worlds best test writer :P, i'll work on getting those up as soon as i can.

[christianallred]

I added the rest of the typings and it caused Integration tests to fail so must be another bug somewhere :) I'll be trying to get tests to run locally tonight or tomorrow i was having trouble getting them running yesterday

[kamilmysliwiec]

Can you please rebase your PR (or cherry-pick your changes)? This PR contains a few unnecessary commits (and changes) unrelated to the actual fix

[christianallred]

Can you please rebase your PR (or cherry-pick your changes)? This PR contains a few unnecessary commits (and changes) unrelated to the actual fix

Done. Sorry i haven't had time to add the tests. been SUPER busy lately with some real life stuffs. I may have lost some integration updates when i rebased. i'll double check it.

[kamilmysliwiec]

Thanks!