Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): fixed bug that socketOptions object not passed to… #7345

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

alexreal1314
Copy link
Contributor

… amqp connection manager instance

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

fixed issue 7317

Issue Number: 7317

What is the new behavior?

Fixed bug that socketOptions properties are not passed to amqb connection manager server instance.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build d1c85f68-3ec3-4f40-845c-7a735a975e02

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-rmq.ts 0 1 0.0%
Totals Coverage Status
Change from base Build ce0a2540-b950-49bb-85d2-9050e72abb8f: 0.0%
Covered Lines: 5499
Relevant Lines: 5821

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants