-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): add GraphQL Federation samples #7486
docs(samples): add GraphQL Federation samples #7486
Conversation
Add sample-applications for graphql-federation code-first approach nestjs#4686
add graphql-federation schema-first sample applications Closes nestjs#4686
Pull Request Test Coverage Report for Build bcd68310-1d95-420e-a50e-8e88fc03a4de
💛 - Coveralls |
Looks like the samples CI pipeline fails, because the samples I added are three sub folders inside the sample/*/ directory. Any idea on how to restructure the samples? |
Thanks for your contribution! Maybe we can just update the |
That could be a option as well 👍🏻 |
Okay I modified the gulp file for the samples: a39b2c2 |
Finally got it working, sorry about the mess in the commit headers :) |
Thanks @Flusinerd! I'll review this PR as soon as I can |
Thank you! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No samples available for graphql-federation
Issue Number: #4686
What is the new behavior?
Added three sample apps for code-first and schema-first approach each according to the federation docs
Does this PR introduce a breaking change?
Other information
N/A