Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add GraphQL Federation samples #7486

Merged

Conversation

Flusinerd
Copy link
Contributor

@Flusinerd Flusinerd commented Jul 8, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ X ] Other... Please describe: Sample apps for GraphQL Federation (#4686)

What is the current behavior?

No samples available for graphql-federation

Issue Number: #4686

What is the new behavior?

Added three sample apps for code-first and schema-first approach each according to the federation docs

Does this PR introduce a breaking change?

[ ] Yes
[ X ] No

Other information

N/A

Flusinerd added 2 commits July 9, 2021 00:24
Add sample-applications for graphql-federation code-first approach

nestjs#4686
add graphql-federation schema-first sample applications

Closes nestjs#4686
@Flusinerd Flusinerd changed the title docs(samples): add graphql-federation samples docs(samples): add GraphQL Federation samples Jul 8, 2021
@coveralls
Copy link

coveralls commented Jul 8, 2021

Pull Request Test Coverage Report for Build bcd68310-1d95-420e-a50e-8e88fc03a4de

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.468%

Totals Coverage Status
Change from base Build 19371806-7a0c-4700-bb78-0ee08bdf48a9: 0.0%
Covered Lines: 5499
Relevant Lines: 5821

💛 - Coveralls

@Flusinerd
Copy link
Contributor Author

Looks like the samples CI pipeline fails, because the samples I added are three sub folders inside the sample/*/ directory.

Any idea on how to restructure the samples?

@kamilmysliwiec
Copy link
Member

Thanks for your contribution! Maybe we can just update the samples script instead of restructuring the example?

@Flusinerd
Copy link
Contributor Author

That could be a option as well 👍🏻

@Flusinerd
Copy link
Contributor Author

Flusinerd commented Jul 9, 2021

Okay I modified the gulp file for the samples: a39b2c2
Now it checks if the directory contains a package.json otherwise goes down one directory

@Flusinerd
Copy link
Contributor Author

Finally got it working, sorry about the mess in the commit headers :)

@kamilmysliwiec
Copy link
Member

Thanks @Flusinerd! I'll review this PR as soon as I can

@kamilmysliwiec
Copy link
Member

Thank you!

@Flusinerd Flusinerd deleted the feat/graphql-federation-sample branch July 3, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants