Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cover integration dir on lint-staged config #9676

Merged
merged 1 commit into from
May 27, 2022

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented May 27, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

there's a mismatch between the format npm-script and the files that lint-staged will watch against

"format": "prettier \"**/*.ts\" --ignore-path ./.prettierignore --write && git status",

"packages/**/*.{ts,json}": [

What is the new behavior?

now both are following the same patterns

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 35aa0177-26a2-40f9-bd1d-b67da1a19735

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.107%

Totals Coverage Status
Change from base Build 0b0f62d7-5768-434b-b26f-340c513ce1c1: 0.0%
Covered Lines: 5781
Relevant Lines: 6143

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 2e3727b into nestjs:master May 27, 2022
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the patch-2 branch May 27, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants