Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade eslint to v8 on application files #1919

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes nestjs/nest#14092

What is the new behavior?

no errors on running npm run lint on a brand new nestjs project

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

until we migrate the eslint config to their new format, we cannot use eslint@9

@kamilmysliwiec kamilmysliwiec merged commit 590ad1f into nestjs:master Oct 28, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the patch-1 branch October 28, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest CLI generates new project with eslint v9, but config remains for v8
2 participants