fix(fastify): serve index file when it exists #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the 404 e2e test as code was trying to serve index.html anyway. |
|
Sorry to ping @kamilmysliwiec but is it possible to take a look at it, we would like to migrate to Nest v11 without relying on patch-package ? |
| @@ -80,19 +80,6 @@ describe('Fastify adapter', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('when trying to get a non-existing file', () => { | |||
There was a problem hiding this comment.
this should remain the default behavior unless a flag (TBD which flag) is enabled. For express it is fallthrough: true so I guess we could use it for Fastify too
There was a problem hiding this comment.
You're right, I think it's a good idea, I just made a commit to re-use this flag on fastify, I also updated the tests, it seems to cover all the cases. Tell me what you think
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It sends index file when this file does not exists.
When it does it replies with a 404 not found.
Issue Number: #1583 1583
What is the new behavior?
It sends the index file when file exists.
Does this PR introduce a breaking change?
Other information