Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix]: Fix Another Issue with Nest Router Package and Swagger Integration. #253

Merged
merged 4 commits into from
Jul 14, 2019

Conversation

shekohex
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: nestjsx/nest-router#3

The Issue was previously fixed at #104 , but recently some developers are reporting issue with swagger-ui as described here nestjsx/nest-router#3 (comment). the issue is simply solved by just rerun the route validation function on the route if it has a modulePath.

What is the new behavior?

This issue is now fixed and now @nestjs/swagger should provide the correct ui route
image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@Joel-Raju
Copy link

@kamilmysliwiec, could you merge this PR and release an updated version soon?

Thank you for the awesome work on NestJS.
Joel

@kamilmysliwiec kamilmysliwiec merged commit 81e2a25 into nestjs:master Jul 14, 2019
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants