fix(mikro-orm.health): mikro-orm connection type is deprecated
#2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the abstraction provided by MikroOrm to determine connection status.
|
Thanks a lot, appreciate it! <3 |
BrunnerLivio
pushed a commit
that referenced
this pull request
Sep 14, 2023
Use the abstraction provided by MikroOrm to determine connection status.
BrunnerLivio
pushed a commit
that referenced
this pull request
Sep 14, 2023
Use the abstraction provided by MikroOrm to determine connection status. resolves #2325
|
Released with v10.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the abstraction provided by MikroOrm to determine connection status.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current implementation relies on 'type' being present, which it no longer will be.
Issue Number: #2259
What is the new behavior?
Relying on the MikroOrm.connection.isConnected implementation, which functionally does the same thing, but moves the "supported driver concern" to the library implementing them by using it's abstraction on connections.
Does this PR introduce a breaking change?
We could be more strict about the current peerDep?
"@mikro-orm/core": "*",