[crud-request] - Set filter conditions as array for RequestQueryBuilder?

[chriszrc]

For the RequestQueryBuilder, we can pass in select fields as an array:

const queryString = RequestQueryBuilder
  .create()
  .select(['foo', 'bar'])
  .setFilter({ field: 'foo', operator: CondOperator.NOT_NULL })
  .setFilter({ field: 'bar', operator: CondOperator.NOT_NULL })

but filters have to be chained method calls. Was there an architectural reason for this? If not, this might actually be a PR I can make

[michaelyali]

Actually yeah, there is a code that I will push soon - it will add a method for passing an object of the query params so you'll be free to get rid of chaining. But if you think that you wanna create a PR, I'll be more than happy with that :)

[chriszrc]

Nice! Sorry, you lost me alittle, you already have the working code, but you'd still want a PR?

…

On Wed, Jun 26, 2019, 12:58 PM Michael Yali ***@***.***> wrote: Actually yeah, there is a code that I will push soon - it will add a method for passing an object of the query params so you'll be free to get rid of chaining. But if you think that you wanna create a PR, I'll be more than happy with that :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#131?email_source=notifications&email_token=AGEBMKLV2YYFCY22VMNWUEDP4ONZRA5CNFSM4H3T7JO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUFKSQ#issuecomment-505959754>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGEBMKIJ22M4YVCI4QCW2MLP4ONZRANCNFSM4H3T7JOQ> .

[michaelyali]

@chriszrc I've added a possibility to add params on .create() (https://github.com/nestjsx/crud/wiki/Requests#usage). Hope that helps. Closing this issue for now.

[chriszrc]

Nice! Works great. I did notice that it appears switching to this method that the global config I had setup was no longer respected:

RequestQueryBuilder.setOptions({
       paramNamesMap: {
         filter: ['filter'],
       },
     });

But, I only included that originally because I think I was in between versions, and the backend wasn't accepting filter requests with the "filter[]" param, only "filter", but now I updated everything, and it's all working, so I can just remove this config. But I guess this should still work for users who want to override the param names?

[michaelyali]

Yes, this definitely works for query params names overriding :)