Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add put route to crud controller #109

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Add put route to crud controller #109

merged 4 commits into from
Jun 25, 2019

Conversation

RobotScribe
Copy link
Contributor

No description provided.

@RobotScribe RobotScribe mentioned this pull request Jun 19, 2019
Closed
rubenCodeforges
rubenCodeforges suggested changes Jun 19, 2019
View reviewed changes
Copy link

@rubenCodeforges rubenCodeforges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one general question , why is this needed?
It looks like your replaceOne method has same signature as createOne the only difference is that it does not have a check for entity

packages/crud/lib/enums/crud-actions.enum.d.ts Show resolved Hide resolved
packages/crud-typeorm/src/typeorm-crud.service.ts Show resolved Hide resolved
@RobotScribe RobotScribe force-pushed the add-PUT-route-to-CRUD-Controller branch 2 times, most recently from be0fce1 to 0b8e2e0 Compare June 21, 2019 12:45
@RobotScribe RobotScribe force-pushed the add-PUT-route-to-CRUD-Controller branch 2 times, most recently from 81623be to 758e605 Compare June 24, 2019 16:11
@RobotScribe RobotScribe force-pushed the add-PUT-route-to-CRUD-Controller branch from 758e605 to dbe4212 Compare June 25, 2019 10:20
@michaelyali michaelyali merged commit 607d47e into nestjsx:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelyali michaelyali michaelyali requested changes

@rubenCodeforges rubenCodeforges rubenCodeforges requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobotScribe @Diluka @michaelyali @rubenCodeforges