This repository was archived by the owner on Nov 10, 2021. It is now read-only.
Add LIMIT, ROUNDED_DIV, and SIZEOF macros #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve the "safer" versions of LOG2 and CTZ by setting their parameters to the type (unsigned int) required by their underlying builtins. And add some comments and adjust whitespace.
gerickson
reviewed
Nov 19, 2019
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * | |||
| * Copyright (c) 2012-2018 Nest Labs, Inc. | |||
| * Copyright (c) 2012-2019 Nest Labs, Inc. | |||
There was a problem hiding this comment.
This should add a new "Copyright (c) 2019 Google LLC" line since Nest Labs is no more as a corporate entity.
gerickson
reviewed
Nov 19, 2019
| #ifndef LOG2 | ||
| #define LOG2(x) LOG2_INNER(x, __COUNTER__) | ||
| #define LOG2_INNER(x, C) ({ __typeof__(x) _CC(_x, C) = (x); (_CC(_x, C) != 0) ? 31 - __builtin_clz(_CC(_x, C)) : -1; }) | ||
| #define LOG2_INNER(x, C) ({ unsigned int _CC(_x, C) = (x); (_CC(_x, C) != 0) ? 31 - __builtin_clz(_CC(_x, C)) : -1; }) |
There was a problem hiding this comment.
This change and the one below on 157 seem unrelated. What was the genesis of these? Regardless, they should probably be in a separate PR if they are unrelated to the addition of LIMIT, ROUNDED_DIV, and SIZEOF.
There was a problem hiding this comment.
You're right, these two changes are unrelated to the others. And they're unfinished, too. I'll pull them out into a separate PR.
gerickson
suggested changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve the "safer" versions of LOG2 and CTZ by setting their parameters to the type (unsigned int) that is required by their underlying builtins. And add some comments, and adjust whitespace.