Improve tests on almalinux OSes #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christos Roussidis <xristos.roussidis@gmail.com>
- Check the filesystem as well because xfs is not supported from idmapped mounts. If the system has xfs filesystem the tests will skip idmapped mount tests. - Add lifecycle tests last because they were not respecting the `--disable-idmapped-mount` flag that was being set from the previous checks. Signed-off-by: Christos Roussidis <xristos.roussidis@gmail.com>
Improve kernel header path based on the linux distro that the tests are running. - Drop lsb_release use, use `cat /etc/os-release` instead. - Create a function which defines the kernel headers path based on the host distro. - Use that function in the sysmgr tests. Signed-off-by: Christos Roussidis <xristos.roussidis@gmail.com>
Signed-off-by: Christos Roussidis <xristos.roussidis@gmail.com>
ctalledo
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Looks great in general, thanks @roussidis; just one comment / question.
Signed-off-by: Christos Roussidis <xristos.roussidis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glibc-staticon almalinux 8 and almalinux 9Start sysboxblock after the initialization of the docker because it is dependend on the docker itself to find out the host filesystem