Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a general management of json errors for some types #1127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

helto4real
Copy link
Collaborator

Breaking change

Proposed change

This change is a more robust fix for exceptions thrown when the expected data type does not match with the json that are received from HA. It supports the subset of data types used in the HassClient data model.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 70.49180% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (f0480a1) to head (cbd28fa).

Files Patch % Lines
.../Internal/Json/EnsureExcpectedDatatypeConverter.cs 57% 15 Missing and 1 partial ⚠️
...sClient/Internal/Net/WebSocketTransportPipeline.cs 33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1127   +/-   ##
====================================
- Coverage    82%     82%   -1%     
====================================
  Files       190     191    +1     
  Lines      3779    3825   +46     
  Branches    425     426    +1     
====================================
+ Hits       3113    3144   +31     
- Misses      501     516   +15     
  Partials    165     165           
Flag Coverage Δ
unittests 82% <70%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant