Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding performance tests #1145

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding performance tests #1145

wants to merge 4 commits into from

Conversation

helto4real
Copy link
Collaborator

@helto4real helto4real commented Jul 16, 2024

Breaking change

Proposed change

This PR adds simple performance tests for NetDaemon. For now it is not able to run as part of the CI/CD pipeline but can be run locally.
This is something that will be added in the future.

It adds a performance test server that fakes HA and a NetDaemon client project that contains apps that meassure and logs performance.

The PR also adds a small fix to HomeAssistantConnection that I found when writing the performance tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (f0480a1) to head (0edcb36).

Files Patch % Lines
...mon.HassClient/Internal/HomeAssistantConnection.cs 66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1145   +/-   ##
====================================
- Coverage    82%     82%   -1%     
====================================
  Files       190     190           
  Lines      3779    3784    +5     
  Branches    425     426    +1     
====================================
+ Hits       3113    3116    +3     
- Misses      501     502    +1     
- Partials    165     166    +1     
Flag Coverage Δ
unittests 82% <66%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant