Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show names on mouseover doesnt remember setting #28

Closed
a402245 opened this issue Dec 17, 2022 · 7 comments
Closed

show names on mouseover doesnt remember setting #28

a402245 opened this issue Dec 17, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@a402245
Copy link

a402245 commented Dec 17, 2022

as per title. set "show names on mouseover" to on and click apply. next time loading the game, the setting is not remembered.

@Lisias Lisias self-assigned this Jan 15, 2023
@Lisias Lisias added this to the 2.1.1.12 milestone Jan 15, 2023
@Lisias Lisias added the bug Something isn't working label Jan 15, 2023
@Lisias
Copy link

Lisias commented Jan 15, 2023

Thank you very much for the report, @a402245 . And sorry I didn't noticed it sooner.

Github only warns me about being mentioned (i.e., using @Lisias on the text), not when someone opens an issue!

I'm working on it.

@Lisias
Copy link

Lisias commented Jan 15, 2023

Cross reference: this was also reported on Forum.

@Lisias
Copy link

Lisias commented Jan 15, 2023

It's not only the "showNames", the "enableFlares" also is being ignored.

It's not a typo, it's some shitty code I wrote that screwed up the settings' loading somehow…

Saving is OK.

@Lisias
Copy link

Lisias commented Jan 15, 2023

Well.. Nope. Loading is partially working - the debugMode setting is working fine by example.

So the ConfigNode itself is being loaded fine.

I think the problem is on the KSPe's ConfigNodeWithSteroids.HasNode …. :/

Maybe a different misbehaviour from the same bug reported on KSP-ModularManagement/KSPe#23 ?

@Lisias
Copy link

Lisias commented Jan 15, 2023

YES! The same misbehaviour!

[LOG 00:12:11.839] DOE *****
[LOG 00:12:11.840] DistantFlare = DistantFlare
{
}

[LOG 00:12:11.840] DistantVessel = DistantVessel
{
}

[LOG 00:12:11.840] SkyboxBrightness = SkyboxBrightness
{
}
``

The nodes above should be filled with data, but they are empty!

@Lisias
Copy link

Lisias commented Jan 15, 2023

The issue KSP-ModularManagement/KSPe#23 was bogus.

But the KSPe.ConfigNodeWithSteroids still have a bug on the HasNode method. Handling it on KSP-ModularManagement/KSPe#40

@Lisias
Copy link

Lisias commented Jan 16, 2023

Closing this issue, as KSPe.Light.DOE was updated with the fix mentioned above.

@Lisias Lisias closed this as completed Jan 16, 2023
@Lisias Lisias removed this from the 2.1.1.12 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants