Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on ConfigNodeWithSteroids.HasNode #40

Closed
Lisias opened this issue Jan 15, 2023 · 1 comment
Closed

Bug on ConfigNodeWithSteroids.HasNode #40

Lisias opened this issue Jan 15, 2023 · 1 comment
Assignees
@Lisias
Labels
bug Something isn't working
Milestone
2.4.2.9

Comments

@Lisias
Copy link
Collaborator

Lisias commented Jan 15, 2023

On DOE, issue net-lisias-ksp/DistantObject#28 , I had found that HasNode is not working.

Why?
@Lisias Lisias self-assigned this Jan 15, 2023
@Lisias Lisias added the bug Something isn't working label Jan 15, 2023
@Lisias Lisias mentioned this issue Jan 15, 2023
Closed
@Lisias Lisias added this to the 2.4.2.9 milestone Jan 15, 2023
Lisias added a commit that referenced this issue Jan 15, 2023
@Lisias
Trying to be less smart and more inteligent by avoiding rebuilding a …
59e864d 
…already working wheel. Fixes #40
@Lisias
Copy link
Collaborator Author

Lisias commented Jan 15, 2023

Sometimes it pays to read the fscking documentation (or the VS's Assembly Browser) before trying to pull a smart move.

ConfigNode.CopyTo was already there, ready to be used - there was no need to try to implement a brute force object copier.

Fixed on commit 59e864d .

@Lisias Lisias closed this as completed Jan 15, 2023
Lisias added a commit that referenced this issue Mar 13, 2023
@Lisias
Trying to be less smart and more inteligent by avoiding rebuilding a …
a56b09c 
…already working wheel. Fixes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lisias Lisias

Labels
bug Something isn't working
Projects
None yet
Milestone
2.4.2.9
Development

No branches or pull requests
1 participant
@Lisias