Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Invariant Violation issue #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RNTop
Copy link

@RNTop RNTop commented Jun 6, 2020

fixed Invariant Violation issue

fixed Invariant Violation issue
Copy link
Collaborator

@RickeyWard RickeyWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the color change event was introduced it was introduced passing an HSV value. It does make sense for it to be the same type as the input color. I added 2 of those calls, but I just duplicated the existing call that was already in there. Changing the passed type of this event will be a breaking change for anyone using it. The error you are getting is likely because you (rightly so) expected them to be the same data type, and were possibly using the component as a controlled component.

I don't disagree with this change, other than that it would be a breaking change for anyone who were using these events already. Anyone have any input?

@tkanarsky
Copy link

The Invariant Violation issue caused by null-initialized radius in the component state was fixed by pull request #34. It still hasn't been deployed to npm though. I'm not sure what else this commit is trying to accomplish -- could you please open a specific issue first and describe your symptoms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants