-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update setup key edit layout #190
update setup key edit layout #190
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to requested changes:
-
There is a bug when creating a new key and setting the reusable switch to true but not changing the available uses. When you click Create key, the API endpoind is called with 0 which means unlimited. We should set it to 0 by default (instead of current 1)
(The bug was there before the PR)
-
I think that we should do the same layout as in the UserEdit component:
- We should also close the Setup key detailed view and switch to the table view when clicking Save button. Just like with UserEdit
src/components/SetupKeyEdit.tsx
Outdated
style={{ | ||
height: "100%", | ||
fontSize: "14px", | ||
borderRadius: "2px", | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style={{ | |
height: "100%", | |
fontSize: "14px", | |
borderRadius: "2px", | |
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for these styles, let's do similar to other pages (see the UserEdit component)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/components/SetupKeyEdit.tsx
Outdated
}} | ||
></Paragraph> | ||
{formSetupKey.type === "one-off" ? "One-off" : "Reusable"}, | ||
Available uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Available uses | |
available uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.