Feature/access control #49

braginini · 2022-05-28T09:17:25Z

No description provided.

# Conflicts: # package-lock.json # package.json # src/App.js # src/components/Banner.js # src/components/Footer.js # src/components/addpeer/AddPeerTabSelector.js # src/views/Peers_.js

braginini · 2022-05-28T09:18:22Z

@dataontabs

If I click the Add Peer button on the Peers list the page doesn't navigate to the Add Peer tab but replaces the Peers view with Add Peer view
Copy IP on Peers tab doesn't work. Same for the Setup Keys tab

…'t navigate to the Add Peer tab but replaces the Peers view with Add Peer view; Copy IP on Peers tab doesn't work. Same for the Setup Keys tab;

braginini · 2022-05-29T12:40:45Z

@dataontabs I pushed a missing part. When we have a self-hosted version then in the Add peer tab we should display netbird up command with the management URL
sudo netbird up --management-url http://0.0.0.0:33073

…oups;

…rd into feature/access-control

mlsmaycon · 2022-06-01T21:46:27Z

Should be ok to merge. Just sync between branch/main

braginini · 2022-06-11T21:05:44Z

src/store/rule/types.ts

+    Source: Group[] | string[] | null
+    Destination: Group[] | string[] | null
+    Flow: string
+    Disabled: boolean


Codacy has a fix for the issue: Replace ····Disabled:·boolean with ··Disabled:·boolean;

Suggested change

Disabled: boolean

Disabled: boolean;

braginini · 2022-06-11T21:05:45Z

src/views/Peers.tsx


 const { Title, Paragraph } = Typography;
 const { Column } = Table;
 const { confirm } = Modal;

 interface PeerDataTable extends Peer {
-    key: string
+    key: string;


Codacy has a fix for the issue: Replace ···· with ··

Suggested change

key: string;

key: string;

braginini · 2022-06-11T21:05:46Z

src/components/AccessControlNew.tsx

+                                    />*/}
+
+                                    <Radio.Group
+                                        options={optionsDisabledEnabled}


Codacy has a fix for the issue: Delete ····················

Suggested change

options={optionsDisabledEnabled}

options={optionsDisabledEnabled}

braginini · 2022-06-11T21:05:48Z

src/components/PeerGroupsUpdate.tsx

+                                                <Option key={m}>{optionRender(m)}</Option>
+                                            )
+                                        }
+                                    </Select>


Codacy has a fix for the issue: Delete ··················

Suggested change

</Select>

</Select>

braginini · 2022-06-11T21:05:49Z

src/views/Peers.tsx

+        return (
+            <Popover key={peerToAction.key} content={mainContent} title={null}>
+                <Button type="link" onClick={() => setUpdateGroupsVisible(peerToAction, true)}>{label}</Button>
+            </Popover>


Codacy has a fix for the issue: Delete ······

Suggested change

</Popover>

</Popover>

braginini · 2022-06-11T21:05:50Z

src/views/Peers.tsx

+            setUpdateGroupsVisible({} as Peer, false)
+            dispatch(peerActions.resetSavedGroups(null))
+        } else if (savedGroups.error) {
+            message.error({ content: 'Failed to update peer groups. You might not have enough permissions.', key: saveGroupsKey, duration: 2, style  });


Codacy has a fix for the issue: Replace ······message.error({·content:·'Failed·to·update·peer·groups.·You·might·not·have·enough·permissions.',·key:·saveGroupsKey,·duration:·2,·style··}); with message.error({⏎········content:⏎··········"Failed·to·update·peer·groups.·You·might·not·have·enough·permissions.",⏎········key:·saveGroupsKey,⏎········duration:·2,⏎········style,

Suggested change

message.error({ content: 'Failed to update peer groups. You might not have enough permissions.', key: saveGroupsKey, duration: 2, style });

message.error({

braginini · 2022-06-11T21:05:51Z

src/views/Peers.tsx

+                    >
+                        <strong>{_g.Name}</strong>
+                    </Tag>
+                    <span style={{fontSize: ".85em"}}>{peersCount}</span>


Codacy has a fix for the issue: Replace ····················<span·style={{fontSize:·".85em" with ··········<span·style={{·fontSize:·".85em"·

Suggested change

<span style={{fontSize: ".85em"}}>{peersCount}</span>

<span style={{ fontSize: ".85em" }}>{peersCount}</span>

braginini · 2022-06-11T21:05:52Z

src/store/peer/actions.ts

+  saveGroups: createAsyncAction(
+      'SAVE_PEERS_GROUPS_REQUEST',
+      'SAVE_PEERS_GROUPS_SUCCESS',
+      'SAVE_PEERS_GROUPS_FAILURE',


Codacy has a fix for the issue: Replace ··'SAVE_PEERS_GROUPS_FAILURE', with "SAVE_PEERS_GROUPS_FAILURE"

Suggested change

'SAVE_PEERS_GROUPS_FAILURE',

"SAVE_PEERS_GROUPS_FAILURE"

braginini · 2022-06-11T21:05:53Z

src/store/peer/types.ts

+}
+
+export interface PeerToSave extends Peer {
+  groupsToSave: string[]


Codacy has a fix for the issue: Insert ;

Suggested change

groupsToSave: string[]

groupsToSave: string[];

braginini · 2022-06-11T21:05:54Z

src/views/Peers.tsx

+            const gs = groups
+                .filter(g => g.Peers?.find((_p:GroupPeer) => _p.ID === p.ID))
+                .map(g => ({ID: g.ID, Name: g.Name, PeersCount: g.Peers?.length, Peers: g.Peers || []}))
+            return {


Codacy has a fix for the issue: Insert }));⏎··

Suggested change

return {

}));

braginini · 2022-06-11T21:05:55Z

src/components/Spin.tsx

+        spinning: loading,
+        delay: 1,
+        size: "large"
+    }


Codacy has a fix for the issue: Replace ····} with ··};

Suggested change

}

};

braginini · 2022-06-11T21:05:56Z

src/components/PeerGroupsUpdate.tsx

+        groupsNoId: [],
+        groupsToSave: [],
+        groupsToRemove: [],
+        groupsToAdd: []


Codacy has a fix for the issue: Replace ····groupsToAdd:·[] with groupsToAdd:·[],

Suggested change

groupsToAdd: []

groupsToAdd: [],

braginini · 2022-06-11T21:05:58Z

src/views/AccessControl.tsx

        } else if (deletedRule.error) {
-            message.error({ content: 'Error! Something wrong to delete rule.', key: deleteKey, duration: 2, style  });
+            message.error({ content: 'Failed to remove rule. You might not have enough permissions.', key: deleteKey, duration: 2, style  })


Codacy has a fix for the issue: Replace ······message.error({·content:·'Failed·to·remove·rule.·You·might·not·have·enough·permissions.',·key:·deleteKey,·duration:·2,·style··}) with message.error({⏎········content:⏎··········"Failed·to·remove·rule.·You·might·not·have·enough·permissions.",⏎········key:·deleteKey,⏎········duration:·2,⏎········style,

Suggested change

message.error({ content: 'Failed to remove rule. You might not have enough permissions.', key: deleteKey, duration: 2, style })

message.error({

dataontabs added 11 commits May 4, 2022 11:08

force menu right 6 and bottom 0

3755377

change project to typescript; redux; sagas; ant design

99c714e

refactoring peers layout

b519aff

setup keys list; setup key new; setup key revoke;

725cc74

add peer; create tabs components, create steps components;

4701c20

access control and activity screen

038ee6c

Merge branch 'main' into feature/access-control

1b83954

# Conflicts: # package-lock.json # package.json # src/App.js # src/components/Banner.js # src/components/Footer.js # src/components/addpeer/AddPeerTabSelector.js # src/views/Peers_.js

fix setup key filter; remove old files js;

40636fe

users list

f7f40d3

list users; set tables pagination showSizeChanger to false

6fa0939

add user menu and user menu responsive; add loading on all pages

306fea6

dataontabs and others added 5 commits May 28, 2022 12:22

[fix] If I click the Add Peer button on the Peers list the page doesn…

3e70556

…'t navigate to the Add Peer tab but replaces the Peers view with Add Peer view; Copy IP on Peers tab doesn't work. Same for the Setup Keys tab;

[fix] buttonCopyMessage key

956765f

rules store

011ad3d

rules store

8af69ac

Append management URL on netbird up command if self-hosted

2a5f716

dataontabs and others added 10 commits May 30, 2022 02:03

add/update/delete rule; show tutorial; tags controller; show modal gr…

93487e4

…oups;

Merge branch 'feature/access-control' of github.com:netbirdio/dashboa…

8846991

…rd into feature/access-control

change rule input name

77a9ecd

select tags with peers count

e03c996

access control show groups on popover

c32c944

fix learn more access control link new rule

4434f4f

group routes to peers

ee082cc

group routes to peers

df3a4a9

Merge branch 'main' into feature/access-control

ea7037c

show acl menu

3737c10

mlsmaycon approved these changes Jun 1, 2022

View reviewed changes

braginini commented Jun 11, 2022

View reviewed changes

braginini and others added 10 commits June 12, 2022 09:38

Fix user view to reflect API changes

0d939ed

Sync API payload fields case for peers

87d31da

Sync API payload fields case for users

43be501

Sync API payload fields case for setup keys

6db970a

Sync API payload fields case for rules

279736e

remove warning and search case

d43c1b6

fix filter acls

85b410c

Remove access control image

2522e37

Add default sorting by name

d71938c

Set proper links for ACL docs

3b3315c

mlsmaycon approved these changes Jun 14, 2022

View reviewed changes

mlsmaycon added 4 commits June 14, 2022 23:41

Edit rule on click over name or Srcs and Dests

63b70f4

Sorrt by name using table property

56dc7e0

Move all button to the right

d01fa82

use icon if avatar image is not available

4ef8da8

mlsmaycon merged commit 6724e5b into main Jun 15, 2022

mlsmaycon deleted the feature/access-control branch June 15, 2022 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/access control #49

Feature/access control #49

braginini commented May 28, 2022

braginini commented May 28, 2022 •

edited

Loading

braginini commented May 29, 2022

mlsmaycon commented Jun 1, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

braginini Jun 11, 2022

	options={optionsDisabledEnabled}
	options={optionsDisabledEnabled}

	message.error({ content: 'Failed to update peer groups. You might not have enough permissions.', key: saveGroupsKey, duration: 2, style });
	message.error({

	<span style={{fontSize: ".85em"}}>{peersCount}</span>
	<span style={{ fontSize: ".85em" }}>{peersCount}</span>

	message.error({ content: 'Failed to remove rule. You might not have enough permissions.', key: deleteKey, duration: 2, style })
	message.error({

Feature/access control #49

Feature/access control #49

Conversation

braginini commented May 28, 2022

braginini commented May 28, 2022 • edited Loading

braginini commented May 29, 2022

mlsmaycon commented Jun 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

braginini commented May 28, 2022 •

edited

Loading