-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/Disable SSH server in the peers table #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some comments on imports that aren't in use and let's discuss the need for a confirmation window for the SSH server
src/store/group/actions.ts
Outdated
import {ApiError, CreateResponse, DeleteResponse, RequestPayload} from '../../services/api-client/types'; | ||
import { | ||
ApiError, | ||
ChangeResponse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of ChangeResponse seems to be left over of local development
import {ApiError, ChangeResponse, DeleteResponse, RequestPayload} from '../../services/api-client/types'; | ||
import { | ||
ApiError, | ||
ChangeResponse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of CreateResponse seems to be left over of local development
src/store/peer/actions.ts
Outdated
import {Group} from "../group/types"; | ||
import {SetupKey} from "../setup-key/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of SetupKey seems to be left over of local development
src/store/peer/sagas.ts
Outdated
@@ -13,6 +13,8 @@ import actions from './actions'; | |||
import {Group, GroupPeer} from "../group/types"; | |||
import serviceGroup from "../group/service"; | |||
import {actions as groupActions} from "../group"; | |||
import {Rule} from "../rule/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of Rule and peers seems to be left over of local development
src/store/peer/service.ts
Outdated
@@ -1,6 +1,7 @@ | |||
import {ApiResponse, RequestPayload} from '../../services/api-client/types'; | |||
import { apiClient } from '../../services/api-client'; | |||
import { Peer } from './types'; | |||
import {Rule} from "../rule/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import of Rule seems to be left over of local development
No description provided.