Skip to content

[client] Cleanup firewall state on startup #6759

[client] Cleanup firewall state on startup

[client] Cleanup firewall state on startup #6759

Triggered via pull request October 22, 2024 11:12
Status Failure
Total duration 12m 42s
Artifacts

golangci-lint.yml

on: pull_request
codespell
9s
codespell
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 3 warnings
lint (macos-latest): client/firewall/iptables/rule.go#L1
: # github.com/netbirdio/netbird/client/firewall/iptables
lint (macos-latest): client/firewall/iptables/state.go#L35
undefined: routeRules
lint (macos-latest): client/firewall/iptables/state.go#L36
undefined: ipsetCounter
lint (macos-latest): client/firewall/iptables/state.go#L38
undefined: aclEntries
lint (macos-latest): client/firewall/iptables/state.go#L39
undefined: ipsetStore
lint (macos-latest): client/firewall/iptables/state.go#L47
undefined: Create (typecheck)
lint (macos-latest): client/firewall/nftables/state.go#L1
: # github.com/netbirdio/netbird/client/firewall/nftables
lint (macos-latest): client/firewall/nftables/state.go#L38
undefined: Create (typecheck)
lint (macos-latest)
issues found
lint (ubuntu-latest): client/firewall/iptables/acl_linux.go#L380
copylocks: assignment copies lock value to *currentState: github.com/netbirdio/netbird/client/firewall/iptables.ShutdownState (govet)
lint (ubuntu-latest): client/firewall/iptables/router_linux.go#L471
copylocks: assignment copies lock value to *currentState: github.com/netbirdio/netbird/client/firewall/iptables.ShutdownState (govet)
lint (ubuntu-latest)
issues found
lint (windows-latest)
cannot use fm (variable of type *uspfilter.Manager) as manager.Manager value in return statement: *uspfilter.Manager does not implement manager.Manager (wrong type for method Reset)\n\t\thave Reset() error\n\t\twant Reset(*statemanager.Manager) error"
lint (windows-latest)
undefined: Create"
lint (windows-latest)
undefined: Create"
lint (windows-latest)
too many arguments in call to manager.Reset\n\thave (nil)\n\twant ()"
lint (windows-latest)
cannot use fm (variable of type *uspfilter.Manager) as manager.Manager value in return statement: *uspfilter.Manager does not implement manager.Manager (wrong type for method Reset)\n\t\thave Reset() error\n\t\twant Reset(*statemanager.Manager) error)"
lint (windows-latest)
cannot use fm (variable of type *uspfilter.Manager) as manager.Manager value in return statement: *uspfilter.Manager does not implement manager.Manager (wrong type for method Reset)\n\t\thave Reset() error\n\t\twant Reset(*statemanager.Manager) error)"
lint (windows-latest)
golangci-lint exit with code 3
lint (macos-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint (ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint (windows-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/