Seticon only when status changes

This prevents a memory leak with the systray lib when setting the icon every 2 seconds causes a large memory consumption see getlantern/systray#135
netbirdio · Oct 12, 2022 · 3c8e18d · 3c8e18d
1 parent b4e03f4
commit 3c8e18d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/client/ui/client_ui.go b/client/ui/client_ui.go
@@ -324,12 +324,12 @@ func (s *serviceClient) updateStatus() error {
  return err
  }
 
- if status.Status == string(internal.StatusConnected) {
+ if status.Status == string(internal.StatusConnected) && !s.mUp.Disabled() {
  systray.SetIcon(s.icConnected)
  s.mStatus.SetTitle("Connected")
  s.mUp.Disable()
  s.mDown.Enable()
- } else {
+ } else if status.Status != string(internal.StatusConnected) && s.mUp.Disabled() {
  systray.SetIcon(s.icDisconnected)
  s.mStatus.SetTitle("Disconnected")
  s.mDown.Disable()