Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell job #1281

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Add codespell job #1281

merged 9 commits into from
Nov 7, 2023

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@Fantu
Copy link
Contributor

Fantu commented Nov 1, 2023

@mlsmaycon I saw

with:
  only_warn: 1

that make job not failing but only report problem found, I think should be added so will not result in fail for result that should be added in exclusion

@Fantu
Copy link
Contributor

Fantu commented Nov 1, 2023

@mlsmaycon the continue error I suppose can be for:

Words are case sensitive based on how they are written in the dictionary file.

so for:
clientA ==> client
if I understand good should be excluded "client" but if correct this seems to me bad thing that don't permit exclusion check of result instead (or in alternative)

@mlsmaycon
Copy link
Collaborator Author

@mlsmaycon the continue error I suppose can be for:

Words are case sensitive based on how they are written in the dictionary file.

so for: clientA ==> client if I understand good should be excluded "client" but if correct this seems to me bad thing that don't permit exclusion check of result instead (or in alternative)

trying that, thanks for the tip

@Fantu
Copy link
Contributor

Fantu commented Nov 1, 2023

still fails, so seems there is a bug that should be reported
in the meantime I suggest you put
only_warn: 1

@Fantu
Copy link
Contributor

Fantu commented Nov 1, 2023

try erro and clienta, all lower case

@mlsmaycon mlsmaycon merged commit b726b32 into main Nov 7, 2023
16 checks passed
@mlsmaycon mlsmaycon deleted the add-codespell-job branch November 7, 2023 12:37
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
add codespell workflow and fixed spelling issues
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
add codespell workflow and fixed spelling issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants