Fix jwks validation and flag/config overriding #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the jwks expiresInTime is not zero and add a log indicating the new expiration time
Ensure the jwks expiresInTime is not zero and add a log indicating the new expiration time Replace the configuration property only when the flag is being used
surik
approved these changes
Dec 12, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
Ensure the jwks expiresInTime is not zero and add a log indicating the new expiration time Replace the configuration property only when the flag is being used
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
Ensure the jwks expiresInTime is not zero and add a log indicating the new expiration time Replace the configuration property only when the flag is being used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Ensure the jwks expiresInTime is not zero and add a log indicating the new expiration time
Replace the configuration property only when the flag is being used
Issue ticket number and link
fixes #1379
Checklist