Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exit nodes - Windows/macOS support #1726

Merged
merged 27 commits into from
Apr 3, 2024
Merged

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Mar 18, 2024

This PR enhances Netbird's routing capabilities on Windows and macOS, allowing us to use the default route on the client.

  • Host routes are dynamically added/removed based on excluded IP addresses determined by hooks in custom dialers and listeners that are used for management traffic. This prevents management traffic from being routed through the VPN itself.
  • Routes are removed only when their reference count reaches 0, ensuring routes persist while in use.
  • Hooks into peer added/removed events manage routes based on peer IP addresses. This prevents routing loops and ensures dedicated connections to all peers.

Issue ticket number and link

Updates #289

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal force-pushed the feature/exit-nodes-windows branch from cb97589 to e9cf182 Compare March 19, 2024 20:17
Base automatically changed from feature/exit-nodes to main March 21, 2024 15:49
@lixmal lixmal force-pushed the feature/exit-nodes-windows branch from c5ce518 to 21f8b00 Compare March 21, 2024 15:56
@lixmal lixmal changed the title Feature/exit nodes - Windows support Feature/exit nodes - Windows/macOS support Mar 25, 2024
@lixmal lixmal force-pushed the feature/exit-nodes-windows branch from 4cd5ff8 to 63fb62e Compare March 25, 2024 18:35
@lixmal lixmal marked this pull request as ready for review March 25, 2024 19:09
@lixmal lixmal force-pushed the feature/exit-nodes-windows branch 2 times, most recently from a795a84 to e748dd5 Compare March 26, 2024 14:22
@lixmal lixmal force-pushed the feature/exit-nodes-windows branch from e748dd5 to 516f09e Compare March 26, 2024 16:51
@lixmal lixmal requested a review from pascal-fischer March 26, 2024 18:34
@vysecurity
Copy link

vysecurity commented Mar 27, 2024

Are exit nodes added? Netbird appears to have at least 2-3 times the speed.

@Neprena
Copy link

Neprena commented Mar 27, 2024

Are exit nodes added? Netbird appears to have at least 2-3 times the speed.

Not yet, but I think it's imminent.

@lixmal lixmal force-pushed the feature/exit-nodes-windows branch 2 times, most recently from 2739856 to bbe9e07 Compare March 30, 2024 22:17
@lixmal lixmal force-pushed the feature/exit-nodes-windows branch from bbe9e07 to 26c006f Compare March 30, 2024 23:04
@lixmal lixmal merged commit 7938295 into main Apr 3, 2024
21 checks passed
@lixmal lixmal deleted the feature/exit-nodes-windows branch April 3, 2024 09:11
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants