Routes is a map, employing safe read/writes ops #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lixmal
reviewed
Mar 28, 2024
lixmal
reviewed
Mar 28, 2024
lixmal
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Thank you for your contribution @hurricanehrndz. Could you also fix the tests please?
I can definitely take a look at this weekend |
hurricanehrndz
force-pushed
the
fix_1759
branch
2 times, most recently
from
6a638c6 to
c7b974a
Compare
Adding a mutex to the struct although the norm, could not be used due to the state being copied around.
|
@lixmal PR should be good now, squashed all my commits and cleaned up the tests and some formatting issues I had introduce |
|
@lixmal is there anything you require of me? |
mlsmaycon
approved these changes
Apr 11, 2024
lixmal
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a mutex to the struct although the norm, could not be used due to the state being copied around. Fixes #1759
Describe your changes
Issue ticket number and link
Checklist