Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed prefs #1836

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Use fixed prefs #1836

merged 3 commits into from
Apr 12, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Apr 11, 2024

Describe your changes

On some kernels removing ip rules with a bunch of criteria lead to removal of the existing main rule. This approach makes sure we only delete rules of predefined preference

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal merged commit 15a2feb into main Apr 12, 2024
16 checks passed
@lixmal lixmal deleted the fix/use-fixed-prefs branch April 12, 2024 14:07
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@lixmal
Use fixed preference for rules (netbirdio#1836)
e4f1add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixmal @mlsmaycon