Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeem invite only when incoming user was invited #1861

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

This will reduce calls to cache and external IDP managers by reducing the redeem invite calls to only when the invited claim is received.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

This will reduce calls to cache and external IDP managers by reducing the redeem invite calls to only when the invited claim is received.
@mlsmaycon mlsmaycon marked this pull request as ready for review April 18, 2024 16:34
management/server/account.go Outdated Show resolved Hide resolved
@mlsmaycon mlsmaycon merged commit a80c8b0 into main Apr 22, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the redeem-invite-when-invited branch April 22, 2024 09:10
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
checks for users with pending invite status in the cache that already logged in and refresh the cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants