Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/route selection #1865

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Feature/route selection #1865

merged 16 commits into from
Apr 23, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Apr 18, 2024

Describe your changes

Adds CLI and GUI functionality to select or deselect received client routes.

$ netbird routes list -h
List all available network routes.

Usage:
  netbird routes list [flags]

Aliases:
  list, ls

Examples:
  netbird routes list

$ netbird routes select -h
Select a list of routes by identifiers or 'all' to clear all selections and to accept all (including new) routes.
Default mode is replace, use -a to append to already selected routes.

Usage:
  netbird routes select route...|all [flags]

Examples:
  netbird routes select all
  netbird routes select route1 route2
  netbird routes select -a route3

Flags:
  -a, --append   Append to current route selection instead of replacing

$ netbird routes deselect -h
Deselect previously selected routes by identifiers or 'all' to disable accepting any routes.

Usage:
  netbird routes deselect route...|all [flags]

Examples:
  netbird routes deselect all
  netbird routes deselect route1 route2

image

image

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@braginini
Copy link
Contributor

  1. Need to use only identifier without the range in the ID field:
  • ID: hello-172.17.0.0/32
    Network: 172.17.0.0/32
    Status: Selected
    replace with

  • ID: hello
    Network: 172.17.0.0/32
    Status: Selected

  1. UI - Select all, instead of Enable All
  2. UI - Deselect all, instead of Disable All

@braginini braginini self-requested a review April 23, 2024 12:42
@lixmal lixmal merged commit f51dc13 into main Apr 23, 2024
21 checks passed
@lixmal lixmal deleted the feature/route-selection branch April 23, 2024 12:42
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants