Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route selection IDs #1890

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Fix route selection IDs #1890

merged 4 commits into from
Apr 29, 2024

Conversation

lixmal
Copy link
Contributor

@lixmal lixmal commented Apr 25, 2024

Describe your changes

Copying the IDs for routes list accidentally modified the original routes, resulting in a panic.
Now we copy the desired values explicitly

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@lixmal lixmal merged commit e435e39 into main Apr 29, 2024
16 checks passed
@lixmal lixmal deleted the fix/route-selection branch April 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lixmal @mlsmaycon